[PATCH v3 1/2] clocksource/arm_arch_timer: Force per-CPU interrupt to be level-triggered

Marc Zyngier marc.zyngier at arm.com
Sun Jun 12 03:12:40 PDT 2016

On Sat, 11 Jun 2016 13:02:44 +0100
Ben Dooks <bjdooks at googlemail.com> wrote:

> out of interest, do you have a list of what the problems are?

The trigger configuration for per-cpu interrupts silently fails
(because set_irq_type cannot deal with them). Which means we're relying
on whatever configuration the firmware has left in there. Also, the
kernel defaults to considering the interrupt as edge.

What saves most platforms so far is that they are using a GIC:
1) Most GIC implementations have their PPI configuration as RO, which
   means that we can't get it wrong.
2) If using a fasteoi handler, there is no significant difference in the
   flow between edge and level (we're relying on the HW dealing with it,
   so (1) is critical).

If your GIC allows PPI configuration to be written and firmware gets it
wrong, you'll miss interrupts. If you don't have a GIC, all bets are

I've queued a number of patches to solve this, which I hope to send to
tglx tomorrow (after looking at this weekend test run).


Jazz is not dead. It just smells funny.

More information about the linux-amlogic mailing list