[PATCH 6/7] meson: clk: Add support for clock gates

Michael Turquette mturquette at baylibre.com
Tue Jul 5 17:51:08 PDT 2016


Hi Ben,

Quoting Ben Dooks (2016-07-05 11:01:14)
> On 05/07/16 18:56, Alexander Müller wrote:
> > This patch adds support for the meson8b clock gates. Most of
> > them are disabled by Amlogic U-Boot, but need to be enabled
> > for ethernet, USB and many other components.
> > 
> > Signed-off-by: Alexander Müller <serveralex at gmail.com>
> > ---
> 
> This seems to be a lot of structures for clocks that may
> never be use. I think it would be better to provide a custom
> lookup function that creates these as needed and use the ID
> in the dt as a offset+bit id.

We want the real clocks registered so that we can disable spuriously
enabled at late_initcall time with clk_disable_unused.

Furthermore, I'd like to not represent all of these gates in the DT
binding description (see my response to the earlier patches in this
series), since it becomes ABI (and a maintenance nightmare).

Regards,
Mike

> 
> -- 
> Ben Dooks                               http://www.codethink.co.uk/
> Senior Engineer                         Codethink - Providing Genius



More information about the linux-amlogic mailing list