[PATCH v3] firmware: arm_scpi: fix reading sensor values on pre-1.0 SCPI firmwares

Sudeep Holla sudeep.holla at arm.com
Tue Dec 13 06:09:29 PST 2016

On 11/12/16 21:14, Martin Blumenstingl wrote:
> The pre-1.0 SCPI firmwares are using one __le32 as sensor value, while
> the 1.0 SCPI protocol uses two __le32 as sensor values (a total of
> 64bit, split into 32bit upper and 32bit lower value).
> Using an "struct sensor_value" to read the sensor value on a pre-1.0
> SCPI firmware gives garbage in the "hi_val" field. Introducing a
> separate function which handles scpi_ops.sensor_get_value for pre-1.0
> SCPI firmware implementations ensures that we do not read memory which
> was not written by the SCPI firmware (which fixes for example the
> temperature reported by scpi-hwmon).
> Suggested-by: Sudeep Holla <Sudeep.Holla at arm.com>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>

Will send to ARM SoC once the SCPI changes land in mainline or post -rc1.


More information about the linux-amlogic mailing list