[PATCH v2 00/17] afs: Miscellaneous fixes

David Howells dhowells at redhat.com
Thu Jun 18 00:48:43 PDT 2026


Hi Christian,

Can you pick up these miscellaneous AFS fixes, please?

 (1) Fix the CB.InitCallBackState3 service handler to handle an unknown
     server (server pointer is NULL).

 (2) Fix the clobbering of the default error code in
     afs_extract_vl_addrs().

 (3) Fix a NULL pointer in a trace point in afs_get_tree().

 (4) Fix setting of AS_RELEASE_ALWAYS for symlinks (and mountpoints) as
     there's no release_folio function provided.  The pagecache isn't used
     by afs for symlinks and directories.

 (5) Fix the release of op->more_files to Use kvfree().

 (6) Fix erroneous seq |= 1 in volume lookup loop.

 (7) Drop for duplicate server records when parsing DNS reply into the VL
     server list (this is not strictly a bug fix, so could be punted to the
     merge window).

 (8) Fix malfunction in bulk lookup due to change in dir_emit() API added
     to mask off DT_* flags for overlayfs on fuse.

 (9) Fix misplaced inc of net->cells_outstanding causing netns destruction
     hang.

(10) Fix reinitialisation of afs_vnode::lock_work.  Not reinitialising it
     after allocation seems to upset DEBUG_OBJECTS despite there being an
     slab init-once handler provided.

(11) Fix callback service message parsers to pass through -EAGAIN when
     insufficient data yet received.

(12) Fix double netfs_inode initialisation in afs_root_iget().

(13) Further fixing of AS_RELEASE_ALWAYS handling.

(14) Switch to using scoped_seqlock_read() in volume lookup loop as a
     follow up to (6).

(15) Fix leak of a volume we failed to get because its refcount had hit 0.

(16) Fix missing NULL pointer check in afs_break_some_callbacks().

(17) Fix leak of empty new vllist in afs_update_cell().

The patches can be found here:

	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=afs-fixes

Thanks,
David

Changes
=======
ver #2)
- Added patches to fix issues raised by Sashiko[1]

[1] https://sashiko.dev/#/patchset/20260609081738.770127-1-dhowells%40re

Dan Carpenter (1):
  afs: Fix error code in afs_extract_vl_addrs()

David Howells (11):
  afs: Remove setting of AS_RELEASE_ALWAYS for symlinks and mountpoints
  afs: Fix bulk lookup malfunction due to change in dir_emit() API
  afs: Fix misplaced inc of net->cells_outstanding
  afs: Fix reinitialisation of the inode, in particular ->lock_work
  afs: Fix callback service message parsers to pass through -EAGAIN
  afs: Fix double netfs initialisation in afs_root_iget()
  afs: Don't use AS_RELEASE_ALWAYS for dir/symlinks part 2
  afs: Remove erroneous seq |= 1 in volume lookup loop
  afs: Fix leak of ungot volume
  afs: Fix missing NULL pointer check in afs_break_some_callbacks()
  afs: Fix vllist leak

Li RongQing (1):
  afs: Remove erroneous seq |= 1 in volume lookup loop

Matvey Kovalev (1):
  afs: fix NULL pointer dereference in afs_get_tree()

Nan Li (1):
  afs: handle CB.InitCallBackState3 requests without a server record

Yuto Ohnuki (1):
  afs: check for duplicate servers in VL server list

Zilin Guan (1):
  afs: use kvfree() to free memory allocated by kvcalloc()

 fs/afs/callback.c     | 15 +++++----------
 fs/afs/cell.c         |  4 +++-
 fs/afs/cmservice.c    |  7 +++++--
 fs/afs/dir.c          | 32 +++++++++++++++++++++-----------
 fs/afs/fs_operation.c |  2 +-
 fs/afs/inode.c        |  8 +++-----
 fs/afs/internal.h     |  2 --
 fs/afs/super.c        |  5 +++--
 fs/afs/vl_list.c      | 18 ++++++++++++++++--
 9 files changed, 57 insertions(+), 36 deletions(-)




More information about the linux-afs mailing list