[PATCH 6.12 63/70] rxrpc: Fix key reference count leak from call->key
Greg Kroah-Hartman
gregkh at linuxfoundation.org
Mon Apr 13 09:00:58 PDT 2026
6.12-stable review patch. If anyone has any objections, please let me know.
------------------
From: Anderson Nascimento <anderson at allelesecurity.com>
commit d666540d217e8d420544ebdfbadeedd623562733 upstream.
When creating a client call in rxrpc_alloc_client_call(), the code obtains
a reference to the key. This is never cleaned up and gets leaked when the
call is destroyed.
Fix this by freeing call->key in rxrpc_destroy_call().
Before the patch, it shows the key reference counter elevated:
$ cat /proc/keys | grep afs at 54321
1bffe9cd I--Q--i 8053480 4169w 3b010000 1000 1000 rxrpc afs at 54321: ka
$
After the patch, the invalidated key is removed when the code exits:
$ cat /proc/keys | grep afs at 54321
$
Fixes: f3441d4125fc ("rxrpc: Copy client call parameters into rxrpc_call earlier")
Signed-off-by: Anderson Nascimento <anderson at allelesecurity.com>
Co-developed-by: David Howells <dhowells at redhat.com>
Signed-off-by: David Howells <dhowells at redhat.com>
Reviewed-by: Jeffrey Altman <jaltman at auristor.com>
cc: Marc Dionne <marc.dionne at auristor.com>
cc: Simon Horman <horms at kernel.org>
cc: linux-afs at lists.infradead.org
cc: stable at kernel.org
Link: https://patch.msgid.link/20260408121252.2249051-9-dhowells@redhat.com
Signed-off-by: Jakub Kicinski <kuba at kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
net/rxrpc/call_object.c | 1 +
1 file changed, 1 insertion(+)
--- a/net/rxrpc/call_object.c
+++ b/net/rxrpc/call_object.c
@@ -690,6 +690,7 @@ static void rxrpc_destroy_call(struct wo
rxrpc_put_bundle(call->bundle, rxrpc_bundle_put_call);
rxrpc_put_peer(call->peer, rxrpc_peer_put_call);
rxrpc_put_local(call->local, rxrpc_local_put_call);
+ key_put(call->key);
call_rcu(&call->rcu, rxrpc_rcu_free_call);
}
More information about the linux-afs
mailing list