[PATCH] afs: Merge preference rule failure condition

David Howells dhowells at redhat.com
Mon Jan 6 05:48:35 PST 2025


Lizhi Xu <lizhi.xu at windriver.com> wrote:

>  		argc = afs_split_string(&buf, argv, ARRAY_SIZE(argv));
> -		if (argc < 0)
> -			return argc;
>  		if (argc < 2)
>  			goto inval;

I think this needs to be slightly different.  afs_split_string() will print
error messages and can return an error code, so we should go with that and set
ret to argc and go to done, not inval.

David




More information about the linux-afs mailing list