[PATCH] netfs: Fix setting of BDP_ASYNC from iocb flags
Jens Axboe
axboe at kernel.dk
Tue May 21 08:52:32 PDT 2024
On 5/21/24 9:49 AM, David Howells wrote:
> Fix netfs_perform_write() to set BDP_ASYNC if IOCB_NOWAIT is set rather
> than if IOCB_SYNC is not set. It reflects asynchronicity in the sense of
> not waiting rather than synchronicity in the sense of not returning until
> the op is complete.
>
> Without this, generic/590 fails on cifs in strict caching mode with a
> complaint that one of the writes fails with EAGAIN. The test can be
> distilled down to:
>
> mount -t cifs /my/share /mnt -ostuff
> xfs_io -i -c 'falloc 0 8191M -c fsync -f /mnt/file
> xfs_io -i -c 'pwrite -b 1M -W 0 8191M' /mnt/file
Looks good to me:
Reviewed-by: Jens Axboe <axboe at kernel.dk>
However, I'll note that BDP_ASYNC is horribly named, it should be
BDP_NOWAIT instead. But that's a separate thing, fix looks correct
as-is.
--
Jens Axboe
More information about the linux-afs
mailing list