[PATCH] afs: Fix missing/incorrect unlocking of RCU read lock

Marc Dionne marc.dionne at auristor.com
Wed Jan 17 08:51:44 PST 2024


On Wed, Jan 17, 2024 at 12:21 PM David Howells <dhowells at redhat.com> wrote:
>
> David Howells <dhowells at redhat.com> wrote:
>
> > In afs_proc_addr_prefs_show(), we need to unlock the RCU read lock in both
> > places before returning (and not lock it again).
> >
> > Fixes: f94f70d39cc2 ("afs: Provide a way to configure address priorities")
> > Reported-by: Marc Dionne <marc.dionne at auristor.com>
>
> Actually:
>
> Reported-by: kernel test robot <oliver.sang at intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202401172243.cd53d5f6-oliver.sang@intel.com
> > Signed-off-by: David Howells <dhowells at redhat.com>
> > cc: linux-afs at lists.infradead.org
> > cc: linux-fsdevel at vger.kernel.org
>
> David

The fix looks fine.

Reviewed-by: Marc Dionne <marc.dionne at auristor.com>

Marc



More information about the linux-afs mailing list