[PATCH net] rxrpc: Fix use of Don't Fragment flag

David Howells dhowells at redhat.com
Tue Jan 9 06:16:17 PST 2024


Marc Dionne <marc.dionne at auristor.com> wrote:

> > +{
> > +       if (set)
> > +               ip_sock_set_mtu_discover(local->socket->sk, IP_PMTUDISC_DONT);
> > +       else
> > +               ip_sock_set_mtu_discover(local->socket->sk, IP_PMTUDISC_DO);
> > +}
> 
> Shouldn't those be reversed - don't fragment should be IP_PMTUDISC_DO?

Meh.  Yes.

> Also, and this is probably already an issue with current code, I don't
> think this is effective if the socket is V6, which it will be in most
> cases.

Hmmm...  I guess I should tweak IPV6_MTU_DISCOVER also.

David




More information about the linux-afs mailing list