[PATCH net-next 37/37] rxrpc: Implement RACK/TLP to deal with transmission stalls [RFC8985]

David Howells dhowells at redhat.com
Tue Dec 3 11:54:53 PST 2024


Jakub Kicinski <kuba at kernel.org> wrote:

> On Mon,  2 Dec 2024 14:30:55 +0000 David Howells wrote:
> > +static inline ktime_t us_to_ktime(u64 us)
> > +{
> > +	return us * NSEC_PER_USEC;
> > +}
> 
> Is there a reason this doesn't exist in include/linux/ktime.h ?
> Given ns_to_ktime and ms_to_ktime already exist there adding a local
> but very similarly named helper in a local file appears questionable.

Yeah - I'll move it there.  It's just that winding backwards and forwards
through the patchset sucks if one of the patches modifies a major header.

David




More information about the linux-afs mailing list