[PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code

David Howells dhowells at redhat.com
Wed Aug 28 01:17:57 PDT 2024


Hongbo Li <lihongbo22 at huawei.com> wrote:

> I see reason is u8, so may I use min_t(u8, sp->ack.reason,
> RXRPC_ACK__INVALID)?

No, please don't use min_t(<unsigned type>, ...) if umin() will do.  IIRC,
some arches can't do byte-level arithmetic.

Thanks,
David




More information about the linux-afs mailing list