[PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code

Hongbo Li lihongbo22 at huawei.com
Sun Aug 25 19:50:03 PDT 2024



On 2024/8/24 20:06, David Howells wrote:
> Hongbo Li <lihongbo22 at huawei.com> wrote:
> 
>> -	summary.ack_reason = (sp->ack.reason < RXRPC_ACK__INVALID ?
>> -			      sp->ack.reason : RXRPC_ACK__INVALID);
>> +	summary.ack_reason = min(sp->ack.reason, RXRPC_ACK__INVALID);
> 
> Can you use umin() rather than min(), please?
> 

I see reason is u8, so may I use min_t(u8, sp->ack.reason, 
RXRPC_ACK__INVALID)?

Thanks,
Hongbo


> Thanks,
> David
> 
> 



More information about the linux-afs mailing list