[RFC PATCH 11/53] netfs: Add support for DIO buffering

David Howells dhowells at redhat.com
Fri Nov 17 12:20:25 PST 2023


Jeff Layton <jlayton at kernel.org> wrote:

> > +	struct bio_vec		*direct_bv;	/* DIO buffer list (when handling iovec-iter) */
> >  	void			*netfs_priv;	/* Private data for the netfs */
> > +	unsigned int		direct_bv_count; /* Number of elements in bv[] */
> 
> nit: "number of elements in direct_bv[]"
> 
> Also, just for better readability, can you swap direct_bv and
> netfs_priv? Then at least the array and count are together.

Yeah - and stick a __counted_by() on too.

David




More information about the linux-afs mailing list