[PATCH 1/2] filemap: fix the conditional folio_put in filemap_fault
Matthew Wilcox
willy at infradead.org
Wed May 3 20:34:43 PDT 2023
On Wed, May 03, 2023 at 05:49:36PM +0200, Christoph Hellwig wrote:
> On Wed, May 03, 2023 at 04:48:20PM +0100, Matthew Wilcox wrote:
> > > - folio_put(folio);
> >
> > Why not simply:
> >
> > - if (folio)
> > + if (!IS_ERR_OR_NULL(folio))
>
> no need for the OR_NULL.
Right. I didn't read the whole function.
> But I find the extra label way easier to
> reason about, and it's exactly the same amount of code.
If it were easy to reason about, it would have a less ugly name.
More information about the linux-afs
mailing list