[PATCH net-next 11/13] rxrpc: Show consumed and freed packets as non-dropped in dropwatch
Paolo Abeni
pabeni at redhat.com
Thu Feb 2 02:42:28 PST 2023
On Tue, 2023-01-31 at 17:12 +0000, David Howells wrote:
> Set a reason when freeing a packet that has been consumed such that
> dropwatch doesn't complain that it has been dropped.
>
> Signed-off-by: David Howells <dhowells at redhat.com>
> cc: Marc Dionne <marc.dionne at auristor.com>
> cc: linux-afs at lists.infradead.org
> ---
> net/rxrpc/skbuff.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/rxrpc/skbuff.c b/net/rxrpc/skbuff.c
> index ebe0c75e7b07..944320e65ea8 100644
> --- a/net/rxrpc/skbuff.c
> +++ b/net/rxrpc/skbuff.c
> @@ -63,7 +63,7 @@ void rxrpc_free_skb(struct sk_buff *skb, enum rxrpc_skb_trace why)
> if (skb) {
> int n = atomic_dec_return(select_skb_count(skb));
> trace_rxrpc_skb(skb, refcount_read(&skb->users), n, why);
> - kfree_skb(skb);
> + kfree_skb_reason(skb, SKB_CONSUMED);
Just for the records, and not intending blocking this series, IMHO:
consume_skb(skb);
would probably be more straight-forward/clear.
Cheers,
Paolo
More information about the linux-afs
mailing list