[PATCH] afs: remove redundant overwriting of ret
David Howells
dhowells at redhat.com
Thu Dec 21 06:10:49 PST 2023
Anastasia Belova <abelova at astralinux.ru> wrote:
> @@ -409,7 +409,6 @@ static int afs_update_cell(struct afs_cell *cell)
> if (ret == -ENOMEM)
> goto out_wake;
>
> - ret = -ENOMEM;
> vllist = afs_alloc_vlserver_list(0);
> if (!vllist)
> goto out_wake;
This isn't a sufficient fix.
Yes, you're right, we need to keep ret - but we do need to set -ENOMEM if
!vllist if ret does not hold an error.
David
More information about the linux-afs
mailing list