[PATCH v2 1/6] Add AFS support
Zorro Lang
zlang at redhat.com
Wed Apr 26 22:38:54 PDT 2023
On Wed, Apr 26, 2023 at 09:32:40PM +0100, David Howells wrote:
> Zorro Lang <zlang at redhat.com> wrote:
>
> > > The in-kernel afs fs takes a string in afs mountpoint format as its source.
> >
> > So do we need to change the below line:
> >
> > echo $SCRATCH_DEV | grep -q "^%" > /dev/null 2>&1
> >
> > to
> >
> > echo "$SCRATCH_DEV" | grep -q ^[%#]
> >
> > ?
>
> I think we want to require '%' to force a RW volume. xfstests probably won't
> work on a RO or backup volume.
OK, thanks for this explanation, maybe we can you add this to be a comment of
grep -q "^%". (I can help that when I merge it, if no more other changes).
Now most (5/6) of patches of this patchset are reviewed, if you'd like to add
more things in README or README.config-sections or other docs, I'll wait
the v2 of this patch. Or I'll merge this patchset in next fstests release
(might be this weekend).
Thanks,
Zorro
>
> David
>
More information about the linux-afs
mailing list