[PATCH v2 5/6] afs: Use the operation issue time instead of the reply time for callbacks

[Jeffrey E Altman]

On 8/31/2022 8:57 AM, David Howells (dhowells at redhat.com) wrote:
> rxrpc and kafs between them try to use the receive timestamp on the first
> data packet (ie. the one with sequence number 1) as a base from which to
> calculate the time at which callback promise and lock expiration occurs.
>
> However, we don't know how long it took for the server to send us the reply
> from it having completed the basic part of the operation - it might then,
> for instance, have to send a bunch of a callback breaks, depending on the
> particular operation.
>
> Fix this by using the time at which the operation is issued on the client
> as a base instead.  That should never be longer than the server's idea of
> the expiry time.
>
> Fixes: 781070551c26 ("afs: Fix calculation of callback expiry time")
> Fixes: 2070a3e44962 ("rxrpc: Allow the reply time to be obtained on a client call")
> Suggested-by: Jeffrey E Altman <jaltman at auristor.com>
> Signed-off-by: David Howells <dhowells at redhat.com>

This looks good to me.   Thank you for making the change.

Jeffrey Altman


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4039 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/linux-afs/attachments/20220901/ac7423b6/attachment.p7s>