kafs-client (recent strangeness of with add_key)

[Spencer Olson]

I've been using this patched version without any issues for a while
now such that I forgot that there was an issue (until a recent system
upgrade).

To make my changes easier to digest, I've split my commits on my
github repository into two branches:
  master  branch now only has changes to the base package.
               This includes several fixes and adds some other command
                line options for verbosity
  debian  branch now has my debian build configuration rebased on
                the new master branch

David:  I'd like to request you to do a pull from:
    https://github.com/olsonse/kafs-client master
to get the changes I've made to the base package.  Let me know if  you
really want me to send you a patch file for these various changes.

Bill:  I'd like to request that you pull these same base package
changes in for the debian package that you are maintaining.

Spencer


On Fri, Jun 3, 2022 at 3:30 PM Spencer Olson <olsonse at umich.edu> wrote:
>
> Ok, so I took the suggestions from Chaskiel, implemented them and
> pushed my changes to my repository on GitHub.  Using this right now
> with no issues yet.
>
> On Tue, May 31, 2022 at 8:24 AM Chaskiel Grundman <cgrundman at gmail.com> wrote:
> >
> > The KEY_SPEC_USER_SESSION_KEYRING exists to be the fallback
> > KEY_SPEC_SESSION_KEYRING.
> >
> > From user-session-keyring.7:
> > > The user session keyring is created on demand when a thread requests it or when a thread asks for its session-keyring(7) and that keyring doesn't exist. In the latter case, a user session keyring will be created and, ***if the session keyring wasn't to be created, the user session keyring will be set as the process's actual session keyring***
> >
> >
> > You can try it yourself, with keyctl show
> > Compare
> > keyctl show @s
> > keyctl show @us
> > and keyctl session -- keyctl show @s
> >
> > the strace shows (session present)
> > keyctl(KEYCTL_GET_KEYRING_ID, KEY_SPEC_SESSION_KEYRING, 0) = 66825801
> > keyctl(KEYCTL_DESCRIBE, 66825801, NULL, 0) = 32
> > keyctl(KEYCTL_DESCRIBE, 66825801, "keyring;1000;1000;3f030000;_ses", 32) = 32
> >
> > vs (session not present)
> > keyctl(KEYCTL_GET_KEYRING_ID, KEY_SPEC_SESSION_KEYRING, 0) = 634641843
> > keyctl(KEYCTL_DESCRIBE, 634641843, NULL, 0) = 42
> > keyctl(KEYCTL_DESCRIBE, 634641843,
> > "keyring;1000;65534;1f3f0000;_uid"..., 42) = 42