[PATCH net-next] rxrpc: uninitialized variable in rxrpc_send_ack_packet()

David Howells dhowells at redhat.com
Thu Nov 17 01:44:24 PST 2022


Dan Carpenter <error27 at gmail.com> wrote:

> The "pkt" was supposed to have been deleted in a previous patch.  It
> leads to an uninitialized variable bug.

Weird.  I don't get a compiler warning and the kernel doesn't crash, despite
transmitting millions of acks.

If I disassemble the built code, I see:

   0xffffffff81b09e89 <+723>:   xor    %edi,%edi
   0xffffffff81b09e8b <+725>:   call   0xffffffff811c0bc1 <kfree>

I'm not sure why it's sticking 0 in EDI, though.

David




More information about the linux-afs mailing list