[PATCH v2 13/19] netfs: Add a function to consolidate beginning a read

David Howells dhowells at redhat.com
Wed Mar 9 14:08:58 PST 2022


Jeff Layton <jlayton at redhat.com> wrote:

> > +	rreq->work.func = netfs_rreq_work;
> > +
> 
> ^^^
> This seems like it should be an INIT_WORK call. I assume you're moving
> this here this because you intend to use netfs_alloc_request for writes
> too?

Interesting question.  INIT_WORK() was called in netfs_alloc_request(), so the
lockdep state has already been initialised and may even have been used already
(say, for instance, we do an RMW cycle buffering in the same request struct).

David




More information about the linux-afs mailing list