[bug report] rxrpc: Implement an in-kernel rxperf server for testing purposes

David Howells dhowells at redhat.com
Thu Dec 15 05:39:38 PST 2022


How about the attached?

David
---
commit 934ce17207803f63ef14de1cc74b73caf362d27b
Author: David Howells <dhowells at redhat.com>
Date:   Thu Dec 15 13:35:51 2022 +0000

    rxrpc: rxperf: Fix uninitialised variable
    
    Dan Carpenter sayeth[1]:
    
    The patch 75bfdbf2fca3: "rxrpc: Implement an in-kernel rxperf server
    for testing purposes" from Nov 3, 2022, leads to the following Smatch
    static checker warning:
    
            net/rxrpc/rxperf.c:337 rxperf_deliver_to_call()
            error: uninitialized symbol 'ret'.
    
    Fix this by initialising ret to 0.  The value is only used for tracing
    purposes in the rxperf server.
    
    Reported-by: Dan Carpenter <error27 at gmail.com>
    Signed-off-by: David Howells <dhowells at redhat.com>
    cc: Marc Dionne <marc.dionne at auristor.com>
    cc: linux-afs at lists.infradead.org
    Link: http://lists.infradead.org/pipermail/linux-afs/2022-December/006124.html [1]

diff --git a/net/rxrpc/rxperf.c b/net/rxrpc/rxperf.c
index 66f5eea291ff..d33a109e846c 100644
--- a/net/rxrpc/rxperf.c
+++ b/net/rxrpc/rxperf.c
@@ -275,7 +275,7 @@ static void rxperf_deliver_to_call(struct work_struct *work)
 	struct rxperf_call *call = container_of(work, struct rxperf_call, work);
 	enum rxperf_call_state state;
 	u32 abort_code, remote_abort = 0;
-	int ret;
+	int ret = 0;
 
 	if (call->state == RXPERF_CALL_COMPLETE)
 		return;




More information about the linux-afs mailing list