[PATCH net-next 03/32] rxrpc: Simplify rxrpc_implicit_end_call()

David Howells dhowells at redhat.com
Tue Dec 6 07:59:01 PST 2022


rxrpc_implicit_end_call() can be simplified a bit as it should call
rxrpc_disconnect_call() now that it's being run in process context.

Signed-off-by: David Howells <dhowells at redhat.com>
cc: Marc Dionne <marc.dionne at auristor.com>
cc: linux-afs at lists.infradead.org
---

 net/rxrpc/input.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/net/rxrpc/input.c b/net/rxrpc/input.c
index d0e20e946e48..dbd92f09c2ca 100644
--- a/net/rxrpc/input.c
+++ b/net/rxrpc/input.c
@@ -998,8 +998,6 @@ void rxrpc_input_call_packet(struct rxrpc_call *call, struct sk_buff *skb)
  */
 void rxrpc_implicit_end_call(struct rxrpc_call *call, struct sk_buff *skb)
 {
-	struct rxrpc_connection *conn = call->conn;
-
 	switch (READ_ONCE(call->state)) {
 	case RXRPC_CALL_SERVER_AWAIT_ACK:
 		rxrpc_call_completed(call);
@@ -1014,8 +1012,5 @@ void rxrpc_implicit_end_call(struct rxrpc_call *call, struct sk_buff *skb)
 	}
 
 	rxrpc_input_call_event(call, skb);
-
-	spin_lock(&conn->bundle->channel_lock);
-	__rxrpc_disconnect_call(conn, call);
-	spin_unlock(&conn->bundle->channel_lock);
+	rxrpc_disconnect_call(call);
 }





More information about the linux-afs mailing list