[PATCH] afs: Prefer struct_size over open coded arithmetic
David Howells
dhowells at redhat.com
Tue Nov 2 02:44:57 PDT 2021
Len Baker <len.baker at gmx.com> wrote:
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>
> So, use the struct_size() helper to do the arithmetic instead of the
> argument "size + size * count" in the kzalloc() function.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
>
> Signed-off-by: Len Baker <len.baker at gmx.com>
Acked-by: David Howells <dhowells at redhat.com>
More information about the linux-afs
mailing list