[PATCH] afs: Fix afs_listxattr() to not list afs ACL special xattrs

[David Howells]

Gaja Sophie Peters <gaja.peters at math.uni-hamburg.de> wrote:

> > Fix afs_listxattr() so that it doesn't list any of the AFS ACL xattrs.  It
> > does mean, however, that getfattr won't list them, though they can still be
> > accessed with getxattr() and setxattr().
> This seems by far the cleanest and most simple solution. I tested it now
> and it works for me in all four (six) cases correctly with getxattr and
> listxattr.

Can I put that down as a Tested-by?

> P.S. I found possibly also why adding the line "afs.*  skip" to the file
> "/etc/xattr.conf" didn't change anything a few days ago: when looking
> with strace at the above cp command, it looks for "/usr/etc/xattr.conf",
> but that file doesn't exist of course. Once I copy /etc/xattr.conf to
> /usr/etc/xattr.conf, cp --preseve=xattr doesn't give any error-messages
> any more. Bug in cp? or in some library? anyways, it's not kafs.

You're using Ubuntu, right?  It may put the file in a different place.  Fedora
has:

	[root at andromeda ~]# rpm -ql libattr
	/etc/xattr.conf
	...

Also what version of libattr do you have installed?  I have 2.4.48.

That said, the change that you can see here:

	https://git.savannah.nongnu.org/cgit/attr.git/log/

with subject "xattr.conf: Indicate afs metadata xattrs should be skipped when
copying" hasn't been released yet.  I'll ask Andreas about that.

David