[PATCH] afs: add a return to afs_dir_set_page_dirty()

trix at redhat.com trix at redhat.com
Tue Jun 1 07:08:20 PDT 2021


From: Tom Rix <trix at redhat.com>

With gcc 10.3, this compile error is reported
dir.c: In function 'afs_dir_set_page_dirty':
dir.c:51:1: error: no return statement in function
  returning non-void [-Werror=return-type]

Even though the code is unreachable, add a return
to silence the error.

Signed-off-by: Tom Rix <trix at redhat.com>
---
 fs/afs/dir.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/afs/dir.c b/fs/afs/dir.c
index 78719f2f567e..988766f88d8b 100644
--- a/fs/afs/dir.c
+++ b/fs/afs/dir.c
@@ -48,6 +48,7 @@ static void afs_dir_invalidatepage(struct page *page, unsigned int offset,
 static int afs_dir_set_page_dirty(struct page *page)
 {
 	BUG(); /* This should never happen. */
+	return -EINVAL;
 }
 
 const struct file_operations afs_dir_file_operations = {
-- 
2.26.3




More information about the linux-afs mailing list