[PATCH 2/3] afs: check function return

David Howells dhowells at redhat.com
Mon Jul 12 08:21:26 PDT 2021


Marc Dionne <marc.c.dionne at gmail.com> wrote:

> > @@ -777,7 +777,7 @@ int afs_writepages(struct address_space *mapping,
> >                 mapping->writeback_index = next / PAGE_SIZE;
> 
> Isn't there the same issue with the use of next here.

Good point.

> >                         mapping->writeback_index = next;
> 
> Unrelated to this patch, but since next is a byte offset, should this
> also divide by PAGE_SIZE as above.

Also a good point.  I'll whip up a separate patch for that.

David




More information about the linux-afs mailing list