[PATCH net] rxrpc: Fix handling of an unsupported token type in rxrpc_read()

patchwork-bot+netdevbpf at kernel.org patchwork-bot+netdevbpf at kernel.org
Wed Jan 13 13:50:08 EST 2021


Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Tue, 12 Jan 2021 15:23:51 +0000 you wrote:
> Clang static analysis reports the following:
> 
> net/rxrpc/key.c:657:11: warning: Assigned value is garbage or undefined
>                 toksize = toksizes[tok++];
>                         ^ ~~~~~~~~~~~~~~~
> 
> rxrpc_read() contains two consecutive loops.  The first loop calculates the
> token sizes and stores the results in toksizes[] and the second one uses
> the array.  When there is an error in identifying the token in the first
> loop, the token is skipped, no change is made to the toksizes[] array.
> When the same error happens in the second loop, the token is not skipped.
> This will cause the toksizes[] array to be out of step and will overrun
> past the calculated sizes.
> 
> [...]

Here is the summary with links:
  - [net] rxrpc: Fix handling of an unsupported token type in rxrpc_read()
    https://git.kernel.org/netdev/net/c/d52e419ac8b5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html





More information about the linux-afs mailing list