[PATCH] rxrpc: fix handling of an unsupported token type in rxrpc_read()

David Howells dhowells at redhat.com
Wed Jan 6 16:09:28 EST 2021


Tom Rix <trix at redhat.com> wrote:

> On 1/6/21 11:44 AM, David Howells wrote:
> > Tom Rix <trix at redhat.com> wrote:
> >
> >> These two loops iterate over the same data, i believe returning here is all
> >> that is needed.
> > But if the first loop is made to support a new type, but the second loop is
> > missed, it will then likely oops.  Besides, the compiler should optimise both
> > paths together.
> 
> You are right, I was only considering the existing cases.

Thanks.  Can I put that down as a Reviewed-by?

David




More information about the linux-afs mailing list