[PATCH] fs: afs: Adding new return type vm_fault_t

Souptick Joarder jrdr.linux at gmail.com
Thu May 10 10:33:37 EDT 2018


Hi David,

On Sun, Apr 15, 2018 at 12:53 AM, Souptick Joarder <jrdr.linux at gmail.com> wrote:
> Use new return type vm_fault_t for page_mkwrite
> handler.
>
> Signed-off-by: Souptick Joarder <jrdr.linux at gmail.com>
> Reviewed-by: Matthew Wilcox <mawilcox at microsoft.com>
> ---
>  fs/afs/internal.h | 3 ++-
>  fs/afs/write.c    | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/afs/internal.h b/fs/afs/internal.h
> index f38d6a5..35e405c 100644
> --- a/fs/afs/internal.h
> +++ b/fs/afs/internal.h
> @@ -21,6 +21,7 @@
>  #include <linux/fscache.h>
>  #include <linux/backing-dev.h>
>  #include <linux/uuid.h>
> +#include <linux/mm_types.h>
>  #include <net/net_namespace.h>
>  #include <net/af_rxrpc.h>
>
> @@ -949,7 +950,7 @@ extern int afs_write_end(struct file *file, struct address_space *mapping,
>  extern ssize_t afs_file_write(struct kiocb *, struct iov_iter *);
>  extern int afs_flush(struct file *, fl_owner_t);
>  extern int afs_fsync(struct file *, loff_t, loff_t, int);
> -extern int afs_page_mkwrite(struct vm_fault *);
> +extern vm_fault_t afs_page_mkwrite(struct vm_fault *vmf);
>  extern void afs_prune_wb_keys(struct afs_vnode *);
>  extern int afs_launder_page(struct page *);
>
> diff --git a/fs/afs/write.c b/fs/afs/write.c
> index 9370e2f..5c41274 100644
> --- a/fs/afs/write.c
> +++ b/fs/afs/write.c
> @@ -751,7 +751,7 @@ int afs_flush(struct file *file, fl_owner_t id)
>   * notification that a previously read-only page is about to become writable
>   * - if it returns an error, the caller will deliver a bus error signal
>   */
> -int afs_page_mkwrite(struct vm_fault *vmf)
> +vm_fault_t afs_page_mkwrite(struct vm_fault *vmf)
>  {
>         struct file *file = vmf->vma->vm_file;
>         struct inode *inode = file_inode(file);
> --
> 1.9.1
>

Any comment on this patch ?



More information about the linux-afs mailing list