[PATCH] net: rxrpc: mark expected switch fall-throughs
David Howells
dhowells at redhat.com
Thu Oct 19 14:16:56 PDT 2017
Gustavo A. R. Silva <garsilva at embeddedor.com> wrote:
> + /* fall through */
All new comments in rxrpc should begin with a capital letter; I'm switching to
this as I modify the lines with comments on. Fix checkpatch or gcc or
whatever takes -Wimplicit-fallthrough to stop being silly.
> - /* Fall through */
> -
> + /* fall through */
No. Firstly, it should be 'F'; secondly, don't remove the blank line - it's
there for a reason.
> + /* fall through */
Capital 'F'.
> -
> + /* fall through */
Don't remove the blank line. Capital 'F'.
> + /* fall through */
Capital 'F'.
David
More information about the linux-afs
mailing list