[PATCH net-next 07/15] rxrpc: Fix accidental cancellation of scheduled resend by ACK parser
David Howells
dhowells at redhat.com
Fri Sep 23 11:20:31 PDT 2016
Sergei Shtylyov <sergei.shtylyov at cogentembedded.com> wrote:
> > case RXRPC_ACK_TYPE_NACK:
> > if (anno_type == RXRPC_TX_ANNO_NAK)
> > continue;
> > + if (anno_type == RXRPC_TX_ANNO_RETRANS)
> > + continue;
>
> Why not fold the above 2 *if*s together? Or use *else if* at least?
I have a pending patch that adds something between them.
David
More information about the linux-afs
mailing list