[bug report] [AF_RXRPC]: Make the in-kernel AFS filesystem use AF_RXRPC.

David Howells dhowells at redhat.com
Fri Dec 2 02:43:47 PST 2016


Dan Carpenter <dan.carpenter at oracle.com> wrote:

>    153          afs_send_empty_reply(call);
> 
> If afs_send_empty_reply() has an error besides -ENOMEM then it frees
> call.
> 
>    154  
>    155          afs_break_callbacks(call->server, call->count, call->request);
>                                     ^^^^^^^^^^^^
> NULL dereference.  I feel like the fix is to not free call but really I
> have no idea.

It may be sufficient to take a ref on the server struct.  However, given I'm
bouncing the afs_call struct around between workqueues, refcounting it is
probably a good idea.

David



More information about the linux-afs mailing list