[PATCH] af_rxrpc accept race (was: RxRPC: 3 issues found in my example code)
David Howells
dhowells at redhat.com
Mon May 12 05:50:13 PDT 2014
Tim Smith <tim at electronghost.co.uk> wrote:
> - skb_queue_tail(&local->accept_queue, skb);
> - rxrpc_queue_work(&local->acceptor);
> + rxrpc_accept_incoming_call(local, skb);
The main problem I have with this is that you're putting a lot of work into
the UDP driver's sk_data_ready callback. Some of that work involves memory
allocation with GFP_NOIO or GFP_NOFS - which may not be appropriate for the
context.
David
More information about the linux-afs
mailing list