[PATCH] afs: delete double assignment

David Howells dhowells at redhat.com
Mon Jul 28 08:29:58 PDT 2014


Himangi Saraogi <himangi774 at gmail.com> wrote:

> -	afs_uuid.time_hi_and_version = (uuidtime >> 48) & AFS_UUID_TIMEHI_MASK;
>  	afs_uuid.time_hi_and_version = AFS_UUID_VERSION_TIME;
>  
>  	get_random_bytes(&clockseq, 2);
>  	afs_uuid.clock_seq_low = clockseq;
> -	afs_uuid.clock_seq_hi_and_reserved =
> -		(clockseq >> 8) & AFS_UUID_CLOCKHI_MASK;
>  	afs_uuid.clock_seq_hi_and_reserved = AFS_UUID_VARIANT_STD;

This might be the wrong thing to do.  I wonder if the lines following the ones
deleted should be "|=" rather than "=".  I'll have a look into it.

David



More information about the linux-afs mailing list