[PATCH v2] af_rxrpc: Keep rxrpc_call pointers in a hashtable

[Tim Smith]

On Friday 21 February 2014 11:52:34 David Howells wrote:
> Tim Smith <tim at electronghost.co.uk> wrote:
> > +	hash_for_each_possible_rcu(rxrpc_call_hash, call, hash_node, key) {
> > +		if (call->hash_key == key &&
> > +		    call->call_id == call_id &&
> > +		    call->cid == cid &&
> > +		    call->in_clientflag == clientflag &&
> > +		    call->service_id == service_id &&
> > +		    call->proto == proto &&
> > +		    call->local == localptr &&
> > +		    memcmp(call->peer_ip.ipv6_addr, peer_addr,
> > +			      addr_size) == 0 &&
> > +		    call->epoch == epoch)
> > +			ret = call;
> 
> break?

Aaargh. I had one of those in there. Where did it run away to?
Probably fat fingers on an editor file change warning. Sigh. v3 incoming...

> > +static struct rxrpc_connection *rxrpc_conn_from_local(struct rxrpc_local
> > *local, +					       struct sk_buff *skb,
> > +					       struct rxrpc_skb_priv *sp)
> > +{
> 
> It would be good if this function could use RCU also, but that can be a
> separate patch.

I want to look at the use of rxrpc_local_lock &c and see if I can get rid of 
it, but one thing at a time.

> It's looking a lot better now:-)
> 
> David

-- 
Tim Smith <tim at electronghost.co.uk>
Look at you! The hat, the coat, the crickety-cricket stuff, the.... 
(unenthusiastically) stick of celery, yeah.... brave choice, celery, but 
fair play to you, not a lot of men can carry off a decorative vegetable.
    -- The Doctor, talking to himself
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-afs/attachments/20140221/b53b4e4a/attachment.sig>