[PATCH 0/8] include/net: next set of extern removals

Joe Perches joe at perches.com
Thu Aug 1 12:29:20 EDT 2013


On Thu, 2013-08-01 at 13:04 +0100, David Howells wrote:
> Joe Perches <joe at perches.com> wrote:
> > Standardize on no extern use on function prototypes
> Can we please standardise on _having_ externs on function prototypes?

Why?

What value is there in using extern for function prototypes?

Your argument for "picking out at a glance"
https://lkml.org/lkml/2013/8/1/237
really doesn't make sense to me.

Basically, anything with parentheses that's not a #define
is an extern.

Exceptions exist for extern function pointers, but those
are fairly unusual anyway.  Outside of netfilter,
extern function pointers are only used about a dozen times
total in the kernel tree.

So, please provide some examples supporting your view.





More information about the linux-afs mailing list