[PATCH 2/6] afs: fix wrong comment about volume type

David Howells dhowells at redhat.com
Fri Jun 22 14:14:43 EDT 2012


Yuanhan Liu <yliu.null at gmail.com> wrote:

> The code comment is quite confusing, and according the code, it's
> R/W volume for leading '#' if rwpath=1.
> ...
> - *	"#[cell:]volume[.]"		R/O or R/W volume (rwpath=0),
> - *					 or R/W (rwpath=1) volume
> + *	"#[cell:]volume[.]"		R/O or R/W(rwpath=1) volume

I'm not sure you make it much clearer.  rwpath=0 permits either R/O or R/W to
be used.  Your change suggests that R/W only if rwpath=1.

I'd suggest:

 + *	"#[cell:]volume[.]"		R/O or R/W volume (rwpath=0),
 + *					 or R/W volume only (rwpath=1)

David



More information about the linux-afs mailing list