[PATCH] afs: fix possible null pointer dereference in afs_alloc_server

Denis Kirjanov dkirjanov at hera.kernel.org
Sun May 30 03:59:27 EDT 2010


Fix possible null pointer dereference since kzalloc can return null

Signed-off-by: Denis Kirjanov <dkirjanov at kernel.org>
---
fs/afs/server.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/fs/afs/server.c b/fs/afs/server.c
index f490995..32e2a91 100644
--- a/fs/afs/server.c
+++ b/fs/afs/server.c
@@ -93,7 +93,10 @@ static struct afs_server *afs_alloc_server(struct afs_cell *cell,
 		server->addr.s_addr = addr->s_addr;
 	}
 
-	_leave(" = %p{%d}", server, atomic_read(&server->usage));
+	if (likely(server))
+		_leave(" = %p{%d}", server, atomic_read(&server->usage));
+	else
+		_leave(" = -ENOMEM");
 	return server;
 }
 



More information about the linux-afs mailing list