afs: BUG: using smp_processor_id() in preemptible code

[Sven Schnelle]

Hi David,

my kernel log is scattered with follwing BUG() like this when enabling afs/rxrpc debugging:

[10528.509959] kAFS: Red Hat AFS client v0.1 registering.
[10528.510652] BUG: using smp_processor_id() in preemptible [00000000] code: modprobe/13718
[10528.511460] caller is afs_init+0x116/0x1f3 [kafs]
[10528.512452] Pid: 13718, comm: modprobe Tainted: P         2.6.25-rc8-smp #4
[10528.513450] 
[10528.513451] Call Trace:
[10528.514461]  [<ffffffff80419f0b>] debug_smp_processor_id+0xb3/0xc4
[10528.515457]  [<ffffffff8886b144>] :kafs:afs_init+0x116/0x1f3
[10528.516452]  [<ffffffff803e32f6>] ? request_key+0x0/0x46
[10528.517457]  [<ffffffff80253e82>] sys_init_module+0x9c/0x198
[10528.518452]  [<ffffffff8020c0cb>] system_call_after_swapgs+0x7b/0x80

Now i'm wondering what the preferred way fixing it is: Removing the
processor id from the debug output (which would be my preferred
solution) or fixing the debug macro? What's your opinion on that?

Cheers,

Sven.