[Libusbx-devel] libusbx v1.0.9-rc4 is now available

[Hans de Goede]

Hi,

On 03/30/2012 02:30 PM, Pete Batard wrote:
> On 2012.03.30 13:17, Xiaofan Chen wrote:
>> Take note OpenBSD does not seem to support
>> libusb_get_device_speed() right now.
>
> Good point. Will make sure NEWS mentions that.
>
>> Surely it can be made to work but I am okay to
>> leave it un-implemented for 1.0.9.
>
> The doc for get_device_speed says:
>
> returns a libusb_speed code, where LIBUSB_SPEED_UNKNOWN means that
> the OS doesn't know or doesn't support returning the negotiated speed.
>
> As long as OpenBSD returns LIBUSB_SPEED_UNKNOWN, I think we're good, but I'm not seeing LIBUSB_SPEED_UNKNOWN being set anywhere in the BSD code.
>
> Can you please add a:
> dev->speed = LIBUSB_SPEED_UNKNOWN;
> At line 168 of openbsd_usb.c and confirm that it works? If it does, I'll add it to RC5 so that, at least, the doc doesn't lie.

There is no need for this, this is already done for all platforms in
usbi_alloc_device, so before calling platform specific code.

Regards,

Hans