device filtering support

[Vitali Lovich]

K - I was doing a bunch of backporting from other branches so I probably didn't do a good job of that.  I'll fix it up when I have some time.

Regarding the performance problem I mentioned, it was in respect to a bad application sitting on top of libusb-compat sitting on top of libusb-1.0, so there was all sorts of bad things happening.

From what I've seen on my end, I haven't seen any major performance issues running with the libusbk backend + the polling fix.  I'm not against descriptor caching though if the Windows backend doesn't do it already.

I don't disagree about hotplug; I think it's a very useful feature.

-Vitali

On Feb 5, 2012, at 2:02 AM, Xiaofan Chen wrote:

> On Sun, Feb 5, 2012 at 5:45 PM, Xiaofan Chen <xiaofanc at gmail.com> wrote:
>> On Tue, Jan 31, 2012 at 2:06 PM, Vitali Lovich <vlovich at gmail.com> wrote:
>>> https://github.com/vlovich/libusb/tree/filter_support feature rebase on top of rc3
>>> 
>>> Request for review.  Verified works on Linux.  Pretty sure that it works on
>>> OSX & Windows as those code paths are even simpler.
>> 
>> Going back to the original thread. I still like your idea of try to
>> make sure that the filtering can be performed as early in the stack
>> as possible and reduce the unexpected usb traffic generated.
>> 
>> It seems to me that your filter_support branch does not build
>> under Mac OS X.
>> 
> 
> There is an issue under Windows as well (tested under MinGW).
> 
>  CC     libusb_1_0_la-windows_usb.lo
> os/windows_usb.c: In function 'init_device':
> os/windows_usb.c:1049:3: error: implicit declaration of function 'usbi_vid_pid_p
> asses_fillter' [-Werror=implicit-function-declaration]
> os/windows_usb.c:1050:4: warning: passing argument 4 of 'usbi_log' from incompat
> ible pointer type [enabled by default]
> ./libusbi.h:127:6: note: expected 'const char *' but argument is of type 'struct
> libusb_context *'
> cc1.exe: some warnings being treated as errors
> 
> make[2]: *** [libusb_1_0_la-windows_usb.lo] Error 1
> 
> 
> 
> -- 
> Xiaofan