[PATCH libnl 2/2] rule: Add support for l3mdev in FIB rules

[Thomas Haller]

On Thu, 2017-05-04 at 14:21 -0600, David Ahern wrote:
> On 5/3/17 8:15 PM, David Ahern wrote:
> > On 5/3/17 5:21 PM, David Ahern wrote:

> > 
> > Oops, meant to update that to the form:
> >    int rtnl_rule_get_l3mdev(struct rtnl_rule *rule, uint8_t *val)
> > 
> > Will resend tomorrow
> > 
> 
> Actually, now I recall why I did it this way ... it is consistent
> with
> the other get methods for rtnl_rule.


Hi David,


I merged your two patches
  https://github.com/thom311/libnl/commit/70556f55ce2982ca8de7cfaa433a8a81f101b141

which includes a patch of me that changes the API.

I tend to prefer the API as it is now, but this is merely a subjective opinion,
and the arguments don't seem very strong in either way.

If you dislike anything about it, please send a follow-up patch
or let's discuss it.


Thanks,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20170512/54289dfd/attachment.sig>