[PATCH libnl 09/11] route: Add support for lwtunnel encapsulations

Thomas Haller thaller at redhat.com
Mon Aug 14 02:49:02 PDT 2017


Hi David,



On Fri, 2017-06-30 at 10:48 -0600, David Ahern wrote:
> Add framework to support lwtunnel encapsulations per nexthop.
> 

>  
> +void nh_set_encap(struct rtnl_nexthop *nh, struct rtnl_nh_encap
> *rtnh_encap)
> +{
> +	if (nh->rtnh_encap) {
> +		if (nh->rtnh_encap->ops && nh->rtnh_encap->ops-
> >destructor)
> +			nh->rtnh_encap->ops->destructor(nh-
> >rtnh_encap->priv);


I think it needs "free(nh->rtnh_encap->priv);"
like in rtnl_route_nh_free().


the rest looks good to me,


Thanks!
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20170814/e85b4640/attachment.sig>


More information about the libnl mailing list