[PATCH libnl 03/11] addr: Add implementations for mpls_ntop and mpls_pton

[Thomas Haller]

On Mon, 2017-08-14 at 10:42 +0200, Thomas Haller wrote:
> Hi David,
> 
> sorry for the long delay for response.
> 
> 
> On Fri, 2017-06-30 at 10:48 -0600, David Ahern wrote:
> > Implementations of mpls_ntop and mpls_pton taken from iproute2.
> > 
> > Signed-off-by: David Ahern <dsahern at gmail.com>
> > ---
> >  Makefile.am                  |   3 +-
> >  include/netlink/route/mpls.h |  15 ++++++
> >  lib/mpls.c                   | 108
> > +++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 125 insertions(+), 1 deletion(-)
> >  create mode 100644 include/netlink/route/mpls.h
> >  create mode 100644 lib/mpls.c
> > 
> > diff --git a/Makefile.am b/Makefile.am
> > index 2b817f4a185b..3fd6ba83ad6c 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -323,7 +323,8 @@ lib_libnl_3_la_SOURCES = \
> >  	lib/utils.c \
> >  	lib/version.c \
> >  	lib/hash.c \
> > -	lib/hashtable.c
> > +	lib/hashtable.c \
> > +	lib/mpls.c
> 
> from the name of the header file include/netlink/route/mpls.h, it
> seems
> you want this new file be part of libnl-route-3.so sub-package.

hm, or maybe you want thi just internal API? Then the header should be
in "include/netlink-private" directory.

Then the naming doesn't matter so much -- libnl3 prefixes would still
be nice, but it's fine as is.


Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20170814/13d2b93a/attachment.sig>