[PATCH] lib/route: Export correct ipgre functionality

Thomas Haller thaller at redhat.com
Sun Nov 6 13:34:32 PST 2016


On Sat, 2016-11-05 at 20:44 +0000, Oliver, Jef wrote:
> On Nov 5, 2016 1:09 PM, Thomas Haller <thaller at redhat.com> wrote:
> 

> rtnl_link_get_pmtudisc is already exported in the public API as an
> int. It is in link.h and link.c. the function was reused as a uint8t
> in ipgre.h. So now the same function name is in two places as two
> different types. My original patch fixed that with the rename to
> remove the conflict.
> 


Hi Jef,


I don't see that "rtnl_link_get_pmtudisc is already exported in the
public API":

  `git grep rtnl_link_get_pmtudisc`

yields no results (in public header files).


It used to exist in public header
  include/netlink/route/link/ipgre.h
until https://github.com/thom311/libnl/commit/adb9f5d8fa605a458dbd97411564fae2584af2f7
but then it had the exact same signature.


Long story short, I think now it's all good, isn't it?


best,
Thomas


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20161106/fb823835/attachment.sig>


More information about the libnl mailing list