[PATCH] lib/route: Export correct ipgre functionality

Thomas Haller thaller at redhat.com
Sat Nov 5 10:18:00 PDT 2016


On Wed, 2016-10-05 at 13:20 -0700, Jef Oliver wrote:
> * Rename rtnl_link_get_pmtudisc to rtnl_link_ipgre_get_pmtudisc
>   in ipgre.c, making the function correctly match the exported
>   functionality in ipgre.h. This fixes an error when trying to
>   use the function, returning an incorrect type usage due to the
>   link module already having a function of the same name.
> 
> * Export rtnl_link_is_[ipgre/ipgretap] allowing for usage per
>   documentation.
> 

Hi Jef,


merged as https://github.com/thom311/libnl/commit/d752558bc23430c6c536046ae44b93fd0b099f6c


I didn't like changing ABI, thus I re-added the wrong name (without
public API).


I also dislike the function signature of rtnl_link_ipgre_get_pmtudisc()
which returns a uint8_t instead of a int. But I kept it for consistency
with others... and who know, maybe would be bothered by changing the
API now.


Thanks,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20161105/c24c966f/attachment.sig>


More information about the libnl mailing list