[PATCH] Support RTEXT_FILTER_VF

Thomas Haller thaller at redhat.com
Sun May 29 07:33:30 PDT 2016


On Mon, 2016-05-16 at 16:23 -0700, Jef Oliver wrote:
> This patch adds RTEXT_FILTER_VF mask support for SRIOV VFs. Since
> SRIOV VFs don't have a defined address family (ie bridge), there
> are no new address family specific operations defined.
> 
> Exposing this mask makes rtnl_link_get_num_vfs() properly return
> the number of loaded SRIOV VFs.
> 
> Signed-off-by: Jef Oliver <jef.oliver at intel.com>
> ---


Hi Jef,


your patch looks right to me (except a minor fixup, see link below).

currently libnl doesn't seem to handle information about SRIOV except
get_num_vf(). Is the *only* purpose of this patch to fix
rtnl_link_get_num_vf(), or do you have a more complex use-case?

For bridge types, link_request_update() would set
both IFLA_EXT_MASK=RTEXT_FILTER_VF and later it is overwriten with
IFLA_EXT_MASK=RTEXT_FILTER_BRVLAN.
That seems wrong. How about the follow-up patch:
https://github.com/thom311/libnl/commits/ext_filter_mask



Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20160529/cf30e8ca/attachment.sig>


More information about the libnl mailing list