[PATCH] xfrm: Make character pointers in setters const

Thomas Haller thaller at redhat.com
Sat Jun 25 05:06:30 PDT 2016


On Mon, 2016-06-06 at 15:21 +0200, Thomas Egerer wrote:
> All of these pointers are either strcpy'd or memcpy'd and usually
> const
> in a calling application. Changing them to const in the header does
> not
> break the compatibility and allows for users with const pointers to
> use
> the library without compiler warnings.
> 
> Signed-off-by: Thomas Egerer <thomas.egerer at secunet.com>
> ---
> Hi *,
> 
> we found our compiler nagging about discarding the const qualifier
> from
> various char * parameters when adding states. Since keys and
> algorithm
> names are not modified but only copied, it makes sense to add the
> const
> qualifier to the prototype and the implementation.
> Please note, that this patch is on top of [1], the version on top of
> the
> current master can be found here: [2].
> 
> Cheers,
> Thomas

Hi Thomas,


thanks for the patch. Merged to master:
https://github.com/thom311/libnl/commit/6a9b59ca731c739fd4a5e3cbcac28309ec427f4b

Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20160625/1fbf0a2f/attachment.sig>


More information about the libnl mailing list