[PATCH] sit: Add 6RD support

Thadeu Lima de Souza Cascardo cascardo at redhat.com
Tue Apr 19 06:52:50 PDT 2016


On Fri, Apr 15, 2016 at 03:39:20PM +0200, Thomas Haller wrote:
> On Mon, 2016-02-08 at 08:05 -0200, Thadeu Lima de Souza Cascardo wrote:
> > Handle 6RD prefixes from sit linkinfo.
> > 
> > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo at redhat.com>
> > ---
> 
> Hi Thadeu,
> 
> 
> I finally got around to review your patch and add public API for the
> functionality you add.
> 
> Could you please have a look at "sit-ip6rd" branch [1]
> 
> [1] https://github.com/thom311/libnl/commits/sit-ip6rd
> 
> The first commit is your patch. Then a few internal cleanup patches,
> and lastly adding the public API. I'm mostly interested, whether the
> API makes sense: the naming of the functions and their  arguments, the
> code-comments, and the type of the arguments -- like uint16_t for
> prefixlen?
> 
> 
> Thanks,
> Thomas

Looks good to me. I tested that at least my goal with this patch still works
fine, that is, running nl-monitor link, creating and removing sit devices and
watching the 6rd values. That shows some present bugs in the sit driver that I
tried to address, but still needs to look more into that.

Cascardo.



More information about the libnl mailing list